Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with file output when the name contains . and a .svg render is requested #6

Open
anishshobithps opened this issue Feb 3, 2023 · 9 comments

Comments

@anishshobithps
Copy link

anishshobithps commented Feb 3, 2023

As the title suggests, if the college/university name contains a ., such as St. Joseph Engineering College, the .png does not download due to the St.

image

It works perfectly when I remove it

image

Also, it would be nice if there was a way to download render images in .svg format rather than .png format, or perhaps an option?

@anishshobithps anishshobithps changed the title Issues with file output when the name contains '.' and a '.svg' render is requested Issues with file output when the name contains . and a .svg render is requested Feb 3, 2023
@mbaraa
Copy link
Owner

mbaraa commented Feb 3, 2023

thanks for your notice,
if you can make a pull request with the
suggested changes that would be great.

if not, then I'll fix them as soon as I can!

@mbaraa
Copy link
Owner

mbaraa commented Feb 4, 2023

Fixed the file name issue so far,
for the SVG output, should it be any transparent SVG or like the gdsc logo template's svg?

@anishshobithps
Copy link
Author

Fixed the file name issue so far, for the SVG output, should it be any transparent SVG or like the gdsc logo template's svg?

Thanks for the fixing the name part, for the svg output, its better if its transparent because I have seen multiple use it as website logo

@mbaraa
Copy link
Owner

mbaraa commented Feb 4, 2023

there is a transparent background with the regular PNG download
ezgif com-gif-maker

@anishshobithps
Copy link
Author

anishshobithps commented Feb 4, 2023

there is a transparent background with regular PNG download

Yes, maybe I am a man with who likes clarity 💀, if its not possible no worries :) . As SVG is a vector it looks cleaner and does not pixelate hence the request

@mbaraa
Copy link
Owner

mbaraa commented Feb 4, 2023

ok I'll see what I can do with that 👍🏼

@mbaraa
Copy link
Owner

mbaraa commented Feb 4, 2023

also if you know Go or SvelteKit, feel free to open a pull request, I'm kind of busy these days!

@anishshobithps
Copy link
Author

There is no hurry :), I don't have any knowledge in Go and I have only tried SvelteKit once, I am practically new to web development all together, all the period (.) issue was more important thanks for the fix 👍🏼

@mbaraa
Copy link
Owner

mbaraa commented Feb 4, 2023

Okay then, wish you all the luck,
PS I noticed that you're building a GDSC website, you could use our template if you like to, or even help us to make it better!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants