Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BetrokkeneForeignkey and BetrokkeneForeignKey entites in documentation #211

Closed
hsiliev opened this issue Jul 31, 2024 · 0 comments · Fixed by #222
Closed

BetrokkeneForeignkey and BetrokkeneForeignKey entites in documentation #211

hsiliev opened this issue Jul 31, 2024 · 0 comments · Fixed by #222
Assignees
@bart-maykin
Labels
bug Something isn't working owner: dimpact triage

Comments

@hsiliev
Copy link

hsiliev commented Jul 31, 2024

Product versie / Product version

2.1

Omschrijf het probleem / Describe the bug

  • Generated code from OpenAPI yml contains 2 identical classes: BetrokkeneForeignkey and BetrokkeneForeignKey

Stappen om te reproduceren / Steps to reproduce

  1. Open klantinteracties OpenAPI yml
  2. Go to https://github.com/maykinmedia/open-klant/blob/master/src/openklant/components/klantinteracties/openapi.yaml#L2849-L2880

Verwacht gedrag / Expected behavior

One would expect to have a single class (perhaps BetrokkeneForeignKey) used.
@hsiliev hsiliev added bug Something isn't working triage labels Jul 31, 2024
@bart-maykin bart-maykin self-assigned this Aug 8, 2024
bart-maykin added a commit that referenced this issue Aug 8, 2024
@bart-maykin
🐛 [#211] remove BetrokkeneForeignkey
bb52fff
@bart-maykin bart-maykin mentioned this issue Aug 9, 2024
Merged
@bart-maykin bart-maykin moved this to Implemented in Data en API fundament Aug 9, 2024
@bart-maykin bart-maykin linked a pull request Aug 13, 2024 that will close this issue
Feature/208 expand openapi bug #222
Merged
@github-project-automation github-project-automation bot moved this from Implemented to Done in Data en API fundament Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bart-maykin bart-maykin

Labels
bug Something isn't working owner: dimpact triage
Projects
Data en API fundament
Status: Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Feature/208 expand openapi bug maykinmedia/open-klant
3 participants
@joeribekker @hsiliev @bart-maykin