Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 #568 - fix: correct count #571

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

🐛 #568 - fix: correct count #571

wants to merge 5 commits into from

Conversation

Xaohs
Copy link
Contributor

@Xaohs Xaohs commented Dec 20, 2024

Fixes #568

@Xaohs Xaohs requested a review from SilviaAmAm December 20, 2024 10:52
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.93%. Comparing base (916e481) to head (71cacb0).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #571      +/-   ##
==========================================
+ Coverage   82.92%   82.93%   +0.01%     
==========================================
  Files         208      208              
  Lines        5633     5638       +5     
  Branches      567      567              
==========================================
+ Hits         4671     4676       +5     
  Misses        962      962              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Xaohs Xaohs marked this pull request as ready for review December 20, 2024 11:21
@Xaohs Xaohs requested a review from SilviaAmAm December 20, 2024 11:50
Copy link
Collaborator

@SilviaAmAm SilviaAmAm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Question:
When destroying the list, if a zaak fails, this is shown in the UI because the cases are polled.
But the data of the destruction list is not polled, so the count would need a page refresh to be updated?

@Xaohs Xaohs requested a review from SilviaAmAm December 24, 2024 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bij opnieuw starten vernietigen juiste aantal tonen
3 participants