Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version number doesn't seem to be shown #82

Open
alextreme opened this issue Oct 1, 2024 · 1 comment · May be fixed by maykinmedia/objects-api#475
Open

Version number doesn't seem to be shown #82

alextreme opened this issue Oct 1, 2024 · 1 comment · May be fixed by maykinmedia/objects-api#475
Assignees
Labels
bug Something isn't working owner: maykin

Comments

@alextreme
Copy link
Member

Product versie / Product version

0.8.1

Omschrijf het probleem / Describe the bug

I noticed that the Objects API (2.4.4) isn't showing the version number, not sure if it did so earlier

image

Stappen om te reproduceren / Steps to reproduce

No response

Verwacht gedrag / Expected behavior

No response

@alextreme alextreme added bug Something isn't working triage Triage means the team has not yet refined this issue. owner: maykin labels Oct 1, 2024
@joeribekker joeribekker removed the triage Triage means the team has not yet refined this issue. label Oct 8, 2024
@joeribekker joeribekker moved this from Triage to Todo in Data en API fundament Oct 8, 2024
@danielmursa-dev danielmursa-dev moved this from Implemented to Todo in Data en API fundament Dec 12, 2024
@danielmursa-dev danielmursa-dev moved this from Todo to Implemented in Data en API fundament Dec 13, 2024
@danielmursa-dev danielmursa-dev moved this from Implemented to In Progress in Data en API fundament Dec 31, 2024
@danielmursa-dev
Copy link

I checked where the variable is set, and it is configured correctly in open-api-framework.

Therefore, in order to use this variable, it must be configured as an environment variable.
So in some cases, as here objects-api/src/objects/conf/dev.py, it is set directly in the settings file, others not.

Other options instead is to go through the container args:

  • This can be done manually or, during the build of the container, you must first run the build by passing the variable correctly with the command:
docker compose build --build-arg RELEASE=release.1.0

I also checked the github workflow open-api-workflows to analyse the container build process. The steps seems are correct also here.
I ran a printout during the execution of the workflows, and the variables are displayed correctly:

image

image

So everything seems to be working as expected, but I am not sure about this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working owner: maykin
Projects
Status: In Progress
Development

Successfully merging a pull request may close this issue.

4 participants