-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Django 3.2 #357
Conversation
pep8 is unused, isort now has profiles
These do not require any changes
CI still needs to be updated to actually enforce it
Removed django-sniplates Removed django-hijack, code was updated to reflect this
pyupgrade --py38-plus --keep-runtime-typing --keep-percent-format $(find . -name '*.py')
This removes the new deprecation warnings Some code was update to also remove some warnings, e.g. the new JSONField, or some deprecated stuff from DRF
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #357 +/- ##
==========================================
+ Coverage 94.81% 94.89% +0.08%
==========================================
Files 133 133
Lines 4568 4622 +54
==========================================
+ Hits 4331 4386 +55
+ Misses 237 236 -1 ☔ View full report in Codecov by Sentry. |
Run pyupgrade: pyupgrade --py39-plus --keep-runtime-typing --keep-percent-format $(find . -name '*.py')
This allows newer versions of pip to be used Next commit will update to v7, using the new resolver
Also update djchoices to latest to be able to use the migration tool djchoices will be dropped in the next commit
Run pyupgrade again
73c3d06
to
c0fd0eb
Compare
Use node 18 Update styling from the default template Update tooling from the default template
8f87b3e
to
a5158f1
Compare
For some reason uwsgi doens't ship with wheels
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
-
The landing page looks like this now for me
I suppose it's because landing page styles were deleted without replacement
Could you take a look? -
Also could you please create a list of the changes in this PR since there are a lot of them like this:
- update python from 3.7 to 3.10
- update debian in docker from 10 to 12
- remove libs...
It will help to summarize all changes and what's left to do
Left to do:
|
@@ -0,0 +1,33 @@ | |||
h1, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why has this folder been renamed? Now I can't see if there are changes in files
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was done in the default project at some point. I know next to nothing about scss/saas, so wanted to be as close to what was done as gulp
was removed and maybe did not support the "old" folder name.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
This PR upgrades the project to 3.2, but it does not:
This PR is meant to be reviewed one commit at a time
Supersedes #343, #341