Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Analyze if query params can be used multiple times and if OAS documents it in the correct way #498

Open
annashamray opened this issue Dec 18, 2024 · 0 comments

Comments

@annashamray
Copy link
Collaborator

annashamray commented Dec 18, 2024

Nitpicky, but ideally explode: true would be specified here to indicate that it should be used like ?data_attr=...&data_attr=... (see https://swagger.io/docs/specification/v3_0/serialization/#query-parameters)

For example: https://github.com/open-formulieren/open-forms/blob/3a702080d35c0670588cc69b8e49445e6224989c/src/openforms/appointments/api/views.py#L64

Although looking at it, apparently explode: true is considered the default by OAS3, so I'm not sure if our schema is correct in that case 🤔. Might be something to investigate in another issue

Originally posted by @stevenbal in #488 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Triage
Development

No branches or pull requests

1 participant