Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use design tokens for the 2FA specific (admin) styling #8

Open
sergei-maertens opened this issue Aug 18, 2021 · 0 comments
Open

Use design tokens for the 2FA specific (admin) styling #8

sergei-maertens opened this issue Aug 18, 2021 · 0 comments

Comments

@sergei-maertens
Copy link
Member

The package (from upstream) includes a 2fa.css file which is used to style the wizard - amongst others it includes a background color for the .btn class.

This does not work well together with our custom admin styling overrides, causing mismatched colors that are not easily override-able.

The best solution would be if 2FA uses design tokens for this, which can be included easily by downstream projects.

Example:

Project CSS:

:root {
  --2fa-btn-background: red;
  --2fa-btn-color: white;
}

2fa.css:

.btn {
    background: var(--2fa-btn-background, #79aec8);
    color: var(--2fa-btn-color, #fff);
    /* other rules... */
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant