Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

✨ - feat: radio implemented #103

Merged
merged 3 commits into from
Jul 2, 2024
Merged

✨ - feat: radio implemented #103

merged 3 commits into from
Jul 2, 2024

Conversation

Xaohs
Copy link
Contributor

@Xaohs Xaohs commented Jun 28, 2024

No description provided.

@Xaohs Xaohs requested a review from svenvandescheur June 28, 2024 13:31
svenvandescheur
svenvandescheur requested changes Jul 1, 2024
View reviewed changes
Copy link
Collaborator

@svenvandescheur svenvandescheur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general I'm happy, there are two things that need to be changed:

  • The "on" "off" behavior need to remain intact.
  • A radio should serialize to a string, not an array.

src/components/form/input/input.tsx Outdated Show resolved Hide resolved
src/components/form/form/form.stories.tsx Show resolved Hide resolved
@svenvandescheur svenvandescheur merged commit cd2d329 into main Jul 2, 2024
4 of 7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@svenvandescheur svenvandescheur svenvandescheur requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Xaohs @svenvandescheur