Issue/intl form implementation #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
svenvandescheur
requested changes
Jun 27, 2024
src/components/form/form/form.tsx
Outdated
| @@ -205,11 +217,16 @@ export const Form: React.FC<FormProps> = ({ | |||
| getValueFromFormData(fields, valuesState, field); | |||
|
|
|||
| const error = getErrorFromErrors(fields, errorsState, field); | |||
| const message = | |||
| error === 'Veld "{name}" is verplicht' | |||
There was a problem hiding this comment.
Can we move this to a constants somwhere next to the validator? And us it a much as possible (except for the useInt.formatMessage call which needs to be a string literal)?
src/lib/form/validation.ts
Outdated
| @@ -18,7 +18,7 @@ export type Validator = ( | |||
| export const validateRequired: Validator = ( | |||
| value, | |||
| field, | |||
| message = 'Field "{name}" is required', | |||
| message = 'Veld "{name}" is verplicht', | |||
There was a problem hiding this comment.
So this can be a constant, optionally document form behaviour overriding the final label
src/lib/i18n/messages/en.json
Outdated
| @@ -104,6 +104,11 @@ | |||
| "description": "mykn.components.Form: The submit form label", | |||
| "originalDefault": "verzenden" | |||
| }, | |||
| "mykn.components.Form.labelValidationErrorRequired": { | |||
| "defaultMessage": "Veld {name} is verplicht", | |||
There was a problem hiding this comment.
This one needs to be translated
svenvandescheur
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.