Fix the value shown on a balance update transaction #1448
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed today that when editing a balance update transaction the amount shown didn't respect the currency steps. After some playing around and looking at the normal transaction (which worked correctly), I believe this fix is appropriate. I tested this locally and it works great (I tested USD and JPY for different precision values from currencies.yml)
This is where I saw the
value
field for themoney_field
of a normal transaction:maybe/app/views/account/transactions/show.html.erb
Line 57 in 56ab092
Before/After: