Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Editing any part of a date causes a page reload before another edit can be done #1415

Closed
ahatzz11 opened this issue Nov 5, 2024 · 1 comment · Fixed by #1479
Closed
Labels
🐛 Bug Something isn't working

Comments

@ahatzz11
Copy link
Contributor

ahatzz11 commented Nov 5, 2024

Describe the bug
When editing a transaction on the /depositories/... page, editing a date causes the page to reload before the date might be 'finished' editing, which causes the edit screen to refresh prematurely. This sort of ends up resulting in only being able to edit one part of a transaction (year, month, day) at a time.

To Reproduce
Steps to reproduce the behavior:

  1. Go to an account
  2. Click on a transaction
  3. Enter a new day
  4. Attempt to enter a new month but...
  5. The page reloads

Expected behavior
I would expect to be able to fully edit a date without the page refreshing out from under me

What version of Maybe are you using?
Hosted

What operating system and browser are you using?
MacOS 14, Chrome 130

Screenshots / Recordings
Video of issue.

@ahatzz11 ahatzz11 added the 🐛 Bug Something isn't working label Nov 5, 2024
@zachgoll
Copy link
Collaborator

zachgoll commented Nov 5, 2024

Editing the date triggers an account sync, so I think the correct way to fix this bug is to remove the global page refresh that the account sync is currently triggering.

We can trigger an update of the graph in the background, but the current behavior is too aggressive; hence causing bugs like this.

In the meantime, until this is fixed, selecting a date with the calendar should work okay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 Bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants