Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

isSet for Grammars, Monoidal Category of grammars, finish Dyck Trace Equivalence #28

Merged
merged 7 commits into from
Oct 28, 2024

Conversation

maxsnew
Copy link
Owner

@maxsnew maxsnew commented Oct 26, 2024

This requires maxsnew/cubical-categorical-logic#115 upstream

@maxsnew maxsnew requested a review from stschaef October 26, 2024 05:25
Copy link
Collaborator

@stschaef stschaef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggesting one name change that I'll change right now, then should be good to merge. The rest of the comments are just discussion

code/cubical/Examples/Indexed/Dyck.agda Show resolved Hide resolved
code/cubical/Grammar/Inductive/HLevels.agda Show resolved Hide resolved
variable ℓ ℓG ℓG' ℓH ℓK ℓL : Level

module _ where
isLang : Grammar ℓG → Type ℓG
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With this interface, the external notion of unambiguity would then be isLang→unambiguous.

The existing definition is in String.Properties and broken at the moment. I still need to fix that, but it's probably not a high priority thing to fix, as its external reasoning that we seemingly don't need because of * continuity

open NatTrans
open NatIso
open isIso
|GRAMMAR| : Category (ℓ-suc ℓ) ℓ
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We've talked about how it would be less universe polymorphic to do so, but defining this as a category could now let us replace unambiguous and StrongEquivalence with the definition of mono and iso from the categories library

@stschaef
Copy link
Collaborator

Looks good assuming CI goes through

@maxsnew maxsnew merged commit 0f878cc into main Oct 28, 2024
2 checks passed
@maxsnew maxsnew deleted the monoidal-category branch October 28, 2024 21:36
nvarner pushed a commit that referenced this pull request Nov 2, 2024
…Equivalence (#28)

* HLevels for grammars, instances for epsilon, tensor
* triangle and pentagon laws
* define monoidal category of grammars
* naturality proofs for some combinators
* finish the Dyck Trace proof using coherence for monoidal categories
* update to CI to use latest cubical-categorical-logic
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants