Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Caching options #90

Closed
BassemN opened this issue Feb 7, 2017 · 3 comments
Closed

Caching options #90

BassemN opened this issue Feb 7, 2017 · 3 comments

Comments

@BassemN
Copy link

BassemN commented Feb 7, 2017

Hello,

Thanks for this awesome library.
I'd like to see more caching options to accelerate lookup speed like caching the database file into memory using shmop PHP extension.

Thanks

@oschwald
Copy link
Member

oschwald commented Feb 7, 2017

The pure PHP reader is file based, not memory based. It would need significant changes to support loading the file into memory like this. However, you generally should be using the C extension in production environments anyway.

For the C extension, there is maxmind/MaxMind-DB-Reader-php#36 for allowing the database to remain open between requests.

For either of these, the change would be in MaxMind\Db, not GeoIp2. Please open an issue at https://github.com/maxmind/MaxMind-DB-Reader-php/issues or add to an existing one like the one above.

@oschwald oschwald closed this as completed Feb 7, 2017
@BassemN
Copy link
Author

BassemN commented Feb 8, 2017

@oschwald Thank you, I'll open an issue there.

@oschwald
Copy link
Member

oschwald commented Feb 8, 2017

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants