Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Passwords are being stored in clear text #45

Open
almereyda opened this issue Dec 7, 2017 · 2 comments
Open

Passwords are being stored in clear text #45

almereyda opened this issue Dec 7, 2017 · 2 comments
Labels

Comments

@almereyda
Copy link
Contributor

Coming from the discussion in #44, we have discovered that credential storage is leaking private credentials where unneccessary. A possibility to circumvent that could be a command switch to launch an interactive REPL to query for the password during runtime, instead of leaving it as plain text in the file system.

Where in

ce7737a

we ask ourselves to find a better way to do this, #25 offers a possible implementation route.

@maxlath
Copy link
Owner

maxlath commented Dec 7, 2017

as I see it:

  • OAuth would be an improvement as it would lower the power of the credentials we have to handle, but we would still have credentials supposedly secret to handle
  • this handling can hardly be done without persisting those credentials to the file system, the alternative proposition to request the password at every session being, in my opinion, not an acceptable solution: as a user, I want to deal with setting up my credentials once and forget about it
  • a possible workaround would be to rely on the system password management system (using a module like keytar maybe?), but that would probably require to run the program in sudo mode at some point

@maxlath
Copy link
Owner

maxlath commented Oct 2, 2019

OAuth authentification is now possible (and recommanded!) in wikibase-cli >= v8 \o/
see config documentation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants