Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add router-store #19

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

PhilFlash
Copy link

Hi,
My PR for router-store
Two remarks:
. i have downgrade typescript to 2.4.2 (for angular cli)
. on my machine, I have errors with prettier:check

yarn run v1.3.2
$ yarn run prettier:base "./{e2e,src}/**/*.{scss,ts}" -l
$ yarn run prettier --single-quote --trailing-comma es5 ./{e2e,src}/**/*.{scss,ts} -l
$ D:\tproj_ang5\angular-ngrx-starter\node_modules\.bin\prettier --single-quote --trailing-comma es5 ./{e2e,src}/**/*.{scss,ts} -l
src\app\core\core.module.ts
src\app\shared\states\root.reducer.ts
src\app\shared\states\router\router.selector.ts
src\styles\shared\_utils.scss
infoerror Visit https://yarnpkg.com/en/docs/cli/run Command failed with exit code 1.
 for documentation about this command.
errorinfo Command failed with exit code 1.
 Visit https://yarnpkg.com/en/docs/cli/runerror for documentation about this command.
 Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.
npm ERR! code ELIFECYCLE
npm ERR! errno 1
npm ERR! [email protected] prettier:check: `yarn run prettier:base-files -l`
npm ERR! Exit status 1
npm ERR! 
npm ERR! Failed at the [email protected] prettier:check script.
npm ERR! This is probably not a problem with npm. There is likely additional logging output above.

A navbar with 2 pages and navigation between these two pages could be an example of navigation with router-store.

@maxime1992
Copy link
Owner

Hi @PhilFlash, thanks for making a PR! :)

I'm super busy right now as I'm moving but I do not forget, even if I can take a look only in 2 weeks or a month.

Thanks for reporting the bugs too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants