Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tail end of output #5

Open
maxgillham opened this issue Oct 5, 2018 · 1 comment
Open

Fix tail end of output #5

maxgillham opened this issue Oct 5, 2018 · 1 comment

Comments

@maxgillham
Copy link
Owner

The while loop goes to (length//(4*end_of_bar))*(4*end_of_bar) which is less than the actual length of the song. It needs to be like this for indexing issues but now the end of songs outputted switch back to original version.

@maxgillham
Copy link
Owner Author

I made it cut off beyond this value, but would be nice to fade out using sox.
Consider putting a fade out before (length//(4*end_of_beat))*(4*end_of_beat), so that when it hits the cutout part, the amplitude it already 0. Just essentially find a way to end song less abrubtly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant