-
Notifications
You must be signed in to change notification settings - Fork 83
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better feedback on feature combinations #263
Comments
Should also consider setting a custom default rust-analyzer command that doesn't emit every single target |
To also improve the documentation using |
@patrickelectric can you provide any context on what combinations of features are allowed? |
This was probably broken on the pass PRs, some work need to be done to fix that besides adding tests in CI. |
I guess i'm trying to understand what is expected to work |
At the moment, check the combinations in CI. For conflict configuration is still necessary to document. |
Would be great to have some documentation on valid combinations of features. This repo makes heavy use of features and some of these are mutually exclusive or have other relationships between them.
These should be documented and invalid combinations should have clear panic messages.
Would also be good to review that all of the valid combinations are tested in CI
i note that
Cargo.toml
contains these comments:additionally, the following feature combinations fail to compile (not exhaustive):
--no-default-features
--no-default-features --features std
--no-default-features --features ardupilotmega
the following combinations do compile (not exhaustive):
--no-default-features --features std,ardupilotmega
The text was updated successfully, but these errors were encountered: