From 78b6ed0d8f3efd82bb249548842669650d2d1839 Mon Sep 17 00:00:00 2001 From: Matthias Frei Date: Mon, 30 Oct 2023 14:13:48 +0100 Subject: [PATCH] fixup: set max concurrent streams to 128 16 might be a bit too "aggressive", set 128 like nginx does by default. --- pkg/grpc/interceptor.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/pkg/grpc/interceptor.go b/pkg/grpc/interceptor.go index dc0da452c8..6fd6d8e7d6 100644 --- a/pkg/grpc/interceptor.go +++ b/pkg/grpc/interceptor.go @@ -165,8 +165,8 @@ func StreamClientInterceptor() grpc.DialOption { // grpc-go prohibits more than MaxConcurrentStreams handlers from running at once, and setting this // option so prevents easy resource exhaustion attacks from malicious clients. func DefaultMaxConcurrentStreams() grpc.ServerOption { - // FIXME this number is pulled out of thin air. - return grpc.MaxConcurrentStreams(16) + // A very generic default value; this is the default that nginx appears to use. + return grpc.MaxConcurrentStreams(128) } // UnaryServerInterceptor constructs the default unary RPC server-side interceptor for