-
-
Notifications
You must be signed in to change notification settings - Fork 66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Error in Tumbnail module #66
Comments
I've never taken relative url's into account when parsing the vtt file. You're right, it's better to resolve the thumbnail url's relative to where the vtt file is located. I'll have this one shipped with 1.5.1 once it arrives (no clear timeline as I've been working on this project on my free time). I'd also happily accept a PR if needed. |
I do not speak English very well, but what did you mean by that phrase? |
I'm sorry, no worries. :-) I'd be happy to accept a pull request (PR). It's basically a way for others to contribute to indigo-player. (See Pull Requests in the navigation bar above). |
I apologize if I ask in the wrong place: where and how can I enter a new setting for the player and then get its value from anywhere in the application? |
This fix loads sprites relative to the location of the VTT file, unless a direct URL is specified in the VTT Resolves matvp91#66 where a thumbnail sprite is loaded from the website root
Apparently the parsing process has some kind of error, if a sprite is specified in the VTT file relative to the VTT file, then the player loads the sprite relative to the root of the site
In the case that is provided in the screenshot, the tooltip.jpg file and tooltip.vtt are next to each other in the same folder
The text was updated successfully, but these errors were encountered: