Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve documentation in code and outside code #83

Open
Brunni opened this issue Sep 9, 2024 · 1 comment
Open

Improve documentation in code and outside code #83

Brunni opened this issue Sep 9, 2024 · 1 comment

Comments

@Brunni
Copy link

Brunni commented Sep 9, 2024

Hi,

I'm very happy about this GELF Logging Extension, as I don't need to use serilog or NLog to get my logs into GrayLog interface.

But I would prefer some more documentation, e.g.

  • Is this extension using async or sync logging? Is there a caching?
  • What happens, if there are connection errors? Is there a retry or is the extension disabled for some time? Where are the logs?
  • Is every message via HTTPS sent as a single request?

Also inside the code:

I don't want to loose log messages, when using this extension and make sure, that everything is configured correctly.

@mattwcole
Copy link
Owner

This library is one of many 3rd party providers for Microsoft.Extensions.Logging that all work in a similar way. To answer your questions:

  • Logging is of course async and there is no no caching (what would be cached?)
  • Connection errors are swallowed silently, there are no retries and no internal logs
  • Messages are sent according to the GELF specification 1 message at a time
  • The GetTimestamp() method is used to populate the timestamp property in the GELF spec

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants