-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bug: panic / runtime error #48
Comments
Cleaned up version of these logs:
|
Also seeing this issue on 9.0.2 and 9.0.4. |
@Rajat-Dabade are you able to look at this? |
@bbodenmiller will look into this today. |
@bbodenmiller @mmjoliver Can you tell me the steps to reproduce this issue? Thank you. |
@Rajat-Dabade I couldn't identify an action that triggered this... I just saw it happen. |
@mmjoliver Does this happen when you try to open a card which consists of any link in the comment by chance? |
@Rajat-Dabade same here, I'm not aware of what exactly triggers the error and subsequent plug-in crash. I wasn't seeing this on 9.0.0 but can't say exact same actions were being performed on that version so perhaps just never triggered the error. |
@Rajat-Dabade I just went through, opening some cards, making new ones, looking at different views, etc. and wasn't able to recreate. |
Downgraded to 8.0.0 and haven't seen a crash yet. |
@bbodenmiller @mmjoliver Can you try adding any link in the comment in any card and see if you are getting the same error while re-opening the same card again? |
@Rajat-Dabade using which version? |
@bbodenmiller using v9.0.4 |
OK, this is interesting. I tailed the logs to watch and added a URL to comments. No errors were logged (at INFO, I changed to DEBUG and reproduced) but the screen refreshed and an error of some sort flashed by, and then "the card is doesn't exist or is inaccessible"
|
@mmjoliver This means you could reproduce the same error you were facing before, right? |
No... I have not seen the panic again. |
@mmjoliver Okay, let me check what could have caused this error, and I will share more of my findings. Thank you. |
I installed this plugin (v 9.0.4)on a self-hosted v9.11.6 instance of Mattermost. I was watching mattermost.log to troubleshoot something when out of the blue I got:
{"timestamp":"2024-12-13 19:55:27.765 Z","level":"warn","msg":"api error response","caller":"app/plugin_api.go:1014","plugin_id":"focalboard","code":"404","error":"\"sql: no rows in result set\"","api":"/api/v2/boards/bt69oh7yogbrsjbwsdyg6rirhur/sharing"} {"timestamp":"2024-12-13 19:55:40.488 Z","level":"error","msg":"Http handler panic","caller":"app/plugin_api.go:1011","plugin_id":"focalboard","panic":"\"runtime error: invalid memory address or nil pointer dereference\"","stack":"\"goroutine 21448 [running]:\nruntime/debug.Stack()\n\truntime/debug/stack.go:24 +0x5e\[ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).panicHandler-fm.(*API).panicHandler.func1.1()\n\tgithub.com/mattermost/mattermost-plugin-boards/server/api/api.go:115](http://ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).panicHandler-fm.(*API).panicHandler.func1.1()%5Cn%5Ctgithub.com/mattermost/mattermost-plugin-boards/server/api/api.go:115) +0x112\npanic({0x12d4940?, 0x25baf00?})\n\truntime/panic.go:770 +0x132\[ngithub.com/mattermost/mattermost-plugin-boards/server/services/permissions/mmpermissions.(*Service).HasPermissionToBoard(0xc00072c5a0](http://ngithub.com/mattermost/mattermost-plugin-boards/server/services/permissions/mmpermissions.(*Service).HasPermissionToBoard(0xc00072c5a0), {0xc000984dc0, 0x1a}, {0xc000a8cecf, 0x1b}, 0x25d4520)\n\[tgithub.com/mattermost/mattermost-plugin-boards/server/services/permissions/mmpermissions/mmpermissions.go:98](http://tgithub.com/mattermost/mattermost-plugin-boards/server/services/permissions/mmpermissions/mmpermissions.go:98) +0x5b1\[ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).handleGetBlocks(0xc000703800](http://ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).handleGetBlocks(0xc000703800), {0x16c1ce8, 0xc0009ab940}, 0xc000a35e60)\n\[tgithub.com/mattermost/mattermost-plugin-boards/server/api/blocks.go:96](http://tgithub.com/mattermost/mattermost-plugin-boards/server/api/blocks.go:96) +0x3b3\[ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).registerBlocksRoutes.(*API).attachSession.func1({0x16c1ce8](http://ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).registerBlocksRoutes.(*API).attachSession.func1(%7B0x16c1ce8), 0xc0009ab940}, 0xc000a35d40)\n\[tgithub.com/mattermost/mattermost-plugin-boards/server/api/auth.go:31](http://tgithub.com/mattermost/mattermost-plugin-boards/server/api/auth.go:31) +0x195\nnet/http.HandlerFunc.ServeHTTP(0x4119db?, {0x16c1ce8?, 0xc0009ab940?}, 0x70aff5f8e108?)\n\tnet/http/server.go:2171 +0x29\[ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).requireCSRFToken-fm.(*API).requireCSRFToken.func1({0x16c1ce8](http://ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).requireCSRFToken-fm.(*API).requireCSRFToken.func1(%7B0x16c1ce8), 0xc0009ab940}, 0xc000a35d40)\n\[tgithub.com/mattermost/mattermost-plugin-boards/server/api/api.go:134](http://tgithub.com/mattermost/mattermost-plugin-boards/server/api/api.go:134) +0x6a\nnet/http.HandlerFunc.ServeHTTP(0xc000ae9458?, {0x16c1ce8?, 0xc0009ab940?}, 0x1419ac0?)\n\tnet/http/server.go:2171 +0x29\[ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).panicHandler-fm.(*API).panicHandler.func1({0x16c1ce8](http://ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).panicHandler-fm.(*API).panicHandler.func1(%7B0x16c1ce8)?, 0xc0009ab940?}, 0xc000b5ad80?)\n\[tgithub.com/mattermost/mattermost-plugin-boards/server/api/api.go:122](http://tgithub.com/mattermost/mattermost-plugin-boards/server/api/api.go:122) +0x87\nnet/http.HandlerFunc.ServeHTTP(0xc000a35c20?, {0x16c1ce8?, 0xc0009ab940?}, 0x87e800?)\n\tnet/http/server.go:2171 +0x29\[ngithub.com/gorilla/mux.(*Router).ServeHTTP(0xc000744fc0](http://ngithub.com/gorilla/mux.(*Router).ServeHTTP(0xc000744fc0), {0x16c1ce8, 0xc0009ab940}, 0xc000a359e0)\n\[tgithub.com/gorilla/[email protected]/mux.go:212](http://tgithub.com/gorilla/[email protected]/mux.go:212) +0x1e2\ngit...","uri":"/api/v2/boards/bt69oh7yogbrsjbwsdyg6rirhur/blocks"} {"timestamp":"2024-12-13 19:55:40.491 Z","level":"warn","msg":"api error response","caller":"app/plugin_api.go:1014","plugin_id":"focalboard","code":"500","error":"\"http handler panic\"","api":"/api/v2/boards/bt69oh7yogbrsjbwsdyg6rirhur/blocks"} {"timestamp":"2024-12-13 19:55:40.557 Z","level":"error","msg":"Http handler panic","caller":"app/plugin_api.go:1011","plugin_id":"focalboard","panic":"\"runtime error: invalid memory address or nil pointer dereference\"","stack":"\"goroutine 21509 [running]:\nruntime/debug.Stack()\n\truntime/debug/stack.go:24 +0x5e\[ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).panicHandler-fm.(*API).panicHandler.func1.1()\n\tgithub.com/mattermost/mattermost-plugin-boards/server/api/api.go:115](http://ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).panicHandler-fm.(*API).panicHandler.func1.1()%5Cn%5Ctgithub.com/mattermost/mattermost-plugin-boards/server/api/api.go:115) +0x112\npanic({0x12d4940?, 0x25baf00?})\n\truntime/panic.go:770 +0x132\[ngithub.com/mattermost/mattermost-plugin-boards/server/services/permissions/mmpermissions.(*Service).HasPermissionToBoard(0xc00072c5a0](http://ngithub.com/mattermost/mattermost-plugin-boards/server/services/permissions/mmpermissions.(*Service).HasPermissionToBoard(0xc00072c5a0), {0xc0007c33e0, 0x1a}, {0xc0006b724f, 0x1b}, 0x25d4520)\n\[tgithub.com/mattermost/mattermost-plugin-boards/server/services/permissions/mmpermissions/mmpermissions.go:98](http://tgithub.com/mattermost/mattermost-plugin-boards/server/services/permissions/mmpermissions/mmpermissions.go:98) +0x5b1\[ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).handleGetMembersForBoard(0xc000703800](http://ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).handleGetMembersForBoard(0xc000703800), {0x16c1ce8, 0xc0006ba2b0}, 0xc000d30b40)\n\[tgithub.com/mattermost/mattermost-plugin-boards/server/api/members.go:55](http://tgithub.com/mattermost/mattermost-plugin-boards/server/api/members.go:55) +0xc9\[ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).registerMembersRoutes.(*API).sessionRequired.(*API).attachSession.func1({0x16c1ce8](http://ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).registerMembersRoutes.(*API).sessionRequired.(*API).attachSession.func1(%7B0x16c1ce8), 0xc0006ba2b0}, 0xc000d30900)\n\[tgithub.com/mattermost/mattermost-plugin-boards/server/api/auth.go:31](http://tgithub.com/mattermost/mattermost-plugin-boards/server/api/auth.go:31) +0x195\nnet/http.HandlerFunc.ServeHTTP(0x4119db?, {0x16c1ce8?, 0xc0006ba2b0?}, 0x70aff5f8e108?)\n\tnet/http/server.go:2171 +0x29\[ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).requireCSRFToken-fm.(*API).requireCSRFToken.func1({0x16c1ce8](http://ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).requireCSRFToken-fm.(*API).requireCSRFToken.func1(%7B0x16c1ce8), 0xc0006ba2b0}, 0xc000d30900)\n\[tgithub.com/mattermost/mattermost-plugin-boards/server/api/api.go:134](http://tgithub.com/mattermost/mattermost-plugin-boards/server/api/api.go:134) +0x6a\nnet/http.HandlerFunc.ServeHTTP(0xc0003cb458?, {0x16c1ce8?, 0xc0006ba2b0?}, 0x1419ac0?)\n\tnet/http/server.go:2171 +0x29\[ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).panicHandler-fm.(*API).panicHandler.func1({0x16c1ce8](http://ngithub.com/mattermost/mattermost-plugin-boards/server/api.(*API).panicHandler-fm.(*API).panicHandler.func1(%7B0x16c1ce8)?, 0xc0006ba2b0?}, 0xc0007823c0?)\n\[tgithub.com/mattermost/mattermost-plugin-boards/server/api/api.go:122](http://tgithub.com/mattermost/mattermost-plugin-boards/server/api/api.go:122) +0x87\nnet/http.HandlerFunc.ServeHTTP(0xc000d307e0?, {0x16c1ce8?, 0xc0006ba2b0?}, 0x87e800?)\n\tnet/http/server.go:2171 +0x29\[ngithub.com/gorilla/mux.(*Router).ServeHTTP(0xc000744fc0](http://ngithub.com/gorilla/mux.(*Router).ServeHTTP(0xc000744fc0), {0x16c1ce8, 0xc0006ba2b0}, 0xc000d2aa20)\n\[tgithub.com/gorilla..](http://tgithub.com/gorilla..).","uri":"/api/v2/boards/bt69oh7yogbrsjbwsdyg6rirhur/members"} {"timestamp":"2024-12-13 19:55:40.558 Z","level":"warn","msg":"api error response","caller":"app/plugin_api.go:1014","plugin_id":"focalboard","code":"500","error":"\"http handler panic\"","api":"/api/v2/boards/bt69oh7yogbrsjbwsdyg6rirhur/members"} {"timestamp":"2024-12-13 19:55:40.588 Z","level":"warn","msg":"api error response","caller":"app/plugin_api.go:1014","plugin_id":"focalboard","code":"400","error":"\"User IDs are empty\"","api":"/api/v2/teams/3nryxymdjffftcrqmf75cpm4kw/users"}
The text was updated successfully, but these errors were encountered: