Conditionally create redis #819
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
I've tested this patch in a deployment I'm running now with no app nodes and I still get an error. Is it working for you, @coltoneshaw? More details in the comment below.
Co-authored-by: Alejandro García Montoro <[email protected]>
|
@agarciamontoro - Fixed, not sure why that didn't reflect here when i tested. |
|
@coltoneshaw - would you be able to resolve the conflicts? |
agarciamontoro
approved these changes
Oct 22, 2024
There was a problem hiding this comment.
Thank you, Colton! Can you resolve the conflicts? It seems it's just a matter of running make assets again
Fixed, not sure why that didn't reflect here when i tested.
Maybe you already had a Terraform state where the count was already resolved. That happened to me the first thing I tried.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conditionally creating redis security groups, only if it's enabled and you have app nodes.