Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update developer-setup.md #1358

Merged
merged 2 commits into from
Apr 29, 2024
Merged

Conversation

varghesejose2020
Copy link
Contributor

Fixed newtabref formating issues

Fixed newtabref formating issues
@mattermost-build
Copy link
Contributor

Hello @varghesejose2020,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@varghesejose2020
Copy link
Contributor Author

@cwarnermm Could you please review these changes?

@cwarnermm cwarnermm self-requested a review April 29, 2024 13:27
@cwarnermm cwarnermm added the 2: Editor Review Requires review by an editor label Apr 29, 2024
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cwarnermm cwarnermm requested a review from amyblais April 29, 2024 13:28
@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor labels Apr 29, 2024
@cwarnermm
Copy link
Member

Just looking for a second approval to merge, @amyblais. Thanks!

@cwarnermm cwarnermm merged commit b6e7f94 into mattermost:master Apr 29, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request Contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants