Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add annotated logging to style guide #1335

Merged
merged 3 commits into from
Feb 13, 2024
Merged

Add annotated logging to style guide #1335

merged 3 commits into from
Feb 13, 2024

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Feb 7, 2024

Summary

Document the style guidelines around annotated logging in the server

Ticket Link

None

@hanzei hanzei added 1: Dev Review Requires review by a core commiter 2: Editor Review Requires review by an editor labels Feb 7, 2024
@hanzei hanzei requested a review from isacikgoz February 7, 2024 10:41
Copy link

github-actions bot commented Feb 7, 2024

Newest code from hanzei has been published to preview environment for Git SHA 693804e

Copy link
Member

@isacikgoz isacikgoz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just a small addition may help readers.

site/content/contribute/more-info/server/style-guide.md Outdated Show resolved Hide resolved
@hanzei hanzei removed the 1: Dev Review Requires review by a core commiter label Feb 13, 2024
Copy link

Newest code from hanzei has been published to preview environment for Git SHA be04bb1

@hanzei hanzei requested a review from cwarnermm February 13, 2024 08:52
Copy link

Newest code from hanzei has been published to preview environment for Git SHA d30fe7a

@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor labels Feb 13, 2024
@cwarnermm cwarnermm merged commit 087c657 into master Feb 13, 2024
5 checks passed
@cwarnermm cwarnermm deleted the annotated-logs branch February 13, 2024 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants