Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Outgoing OAuth Connections #1334

Merged
merged 4 commits into from
Feb 20, 2024
Merged

Outgoing OAuth Connections #1334

merged 4 commits into from
Feb 20, 2024

Conversation

mickmister
Copy link
Contributor

Summary

This PR documents the new Outgoing OAuth Connections feature. These docs are to be linked in the UI at places where the feature is configured.

Ticket Link

Fixes https://mattermost.atlassian.net/browse/MM-56371

Epic https://mattermost.atlassian.net/browse/MM-54990

@mickmister mickmister added the preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories label Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

Newest code from mickmister has been published to preview environment for Git SHA 82ebfce

1 similar comment
Copy link

github-actions bot commented Feb 6, 2024

Newest code from mickmister has been published to preview environment for Git SHA 82ebfce

Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've provided editorial feedback inline.

@cwarnermm cwarnermm added the 1: Dev Review Requires review by a core commiter label Feb 6, 2024
Copy link

github-actions bot commented Feb 6, 2024

Newest code from cwarnermm has been published to preview environment for Git SHA 82ebfce

@mickmister
Copy link
Contributor Author

@cwarnermm Should this doc page be permalinked? Asking now so we can make sure the docs linked in the UI are flexible, as we may end up not wanting this to live in the slash commands docs subpath

@cwarnermm
Copy link
Member

@mickmister - All docs links in-product should be permalinked, yes, as per the Mattermost Handbook policy.

@mickmister
Copy link
Contributor Author

@cwarnermm Do you have any thoughts on where this page should go? The main ask for this has been for using this for slash commands, though it affects other integration types as well

Copy link

Newest code from mickmister has been published to preview environment for Git SHA 04b5089

Co-authored-by: Carrie Warner (Mattermost) <[email protected]>
Copy link

Newest code from mickmister has been published to preview environment for Git SHA 3658db2

@mickmister mickmister requested a review from cwarnermm February 20, 2024 17:41
Copy link

Newest code from mickmister has been published to preview environment for Git SHA 4d03b26

@mickmister
Copy link
Contributor Author

@cwarnermm Can you please take another look at this? The last commit of changes should clear up the detail about what's currently supported. 0/5 if we need to reference the future plans at all 4d03b26

Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really well documented, @mickmister! Thank you!

@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter labels Feb 20, 2024
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 4d03b26

@mickmister mickmister merged commit 6718cb1 into master Feb 20, 2024
5 checks passed
@mickmister mickmister deleted the outgoing-oauth-connections branch February 20, 2024 18:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants