Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update style guide to reflect standard Go module layout #1328

Merged
merged 2 commits into from
Jan 9, 2024

Conversation

hanzei
Copy link
Contributor

@hanzei hanzei commented Jan 9, 2024

Summary

Link to https://go.dev/doc/modules/layout instead of providing our own style guide.

Ticket Link

https://community.mattermost.com/core/pl/fe9oh9srxiyafjm64p8km1nh3a

@hanzei hanzei added the 1: Dev Review Requires review by a core commiter label Jan 9, 2024
@hanzei hanzei requested a review from agnivade January 9, 2024 12:45
Copy link

github-actions bot commented Jan 9, 2024

Newest code from hanzei has been published to preview environment for Git SHA 60fa6da

@hanzei hanzei requested a review from cwarnermm January 9, 2024 12:59
@hanzei hanzei added 2: Editor Review Requires review by an editor and removed 1: Dev Review Requires review by a core commiter labels Jan 9, 2024
Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @hanzei!

@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor labels Jan 9, 2024
Copy link

github-actions bot commented Jan 9, 2024

Newest code from cwarnermm has been published to preview environment for Git SHA 96c566c

@cwarnermm cwarnermm merged commit 9cfa1a1 into master Jan 9, 2024
4 checks passed
@cwarnermm cwarnermm deleted the standard-go-module-layout branch January 9, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants