feat: create code switcher tab #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Visit the preview URL for this PR (updated for commit 40708ac): https://zksync-docs-staging-5eb09--pr8-itsacoyote-devrl-448-blokitwu.web.app (expires Mon, 08 Apr 2024 15:44:12 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 Sign: bfaafba5fa82d4f63473aaa76a21fabf1fbb3a11 |
itsacoyote
force-pushed
the
itsacoyote-devrl-448-tab-content-component
branch
from
e52be8e to
678de53
Compare
dutterbutter
reviewed
Apr 1, 2024
| @@ -0,0 +1,37 @@ | |||
| <script setup lang="ts"> | |||
| defineProps<{ | |||
| items: CodeSwitcherTabItem[]; | |||
There was a problem hiding this comment.
Nit: Can we update the name. CodeSwitcher seems to focused on code whereas its more like a content swticher. Thoughts?
There was a problem hiding this comment.
Sounds good to me, I'll rename 👍🏻
dutterbutter
reviewed
Apr 1, 2024
Comment on lines
+14
to
+18
| label: 'HardHat', | ||
| partial: '_getting-started/_aPartial' | ||
| }, { | ||
| label: 'Forge', | ||
| partial: '_getting-started/_anotherpartial' |
There was a problem hiding this comment.
This is perfect, being able to specify dedicated pages for each partial 💯
dutterbutter
approved these changes
Apr 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What 💻
Why ✋
Evidence 📷
Example set up in the Getting Started page to show how it can be used.
NuxtUI has a UTabs component that can be used plainly if we didn't want to use this. This new component provides a way to have tabbed content that can be loaded from partial markdown files to help split up content and make editing potentially easier.
A future feature to implement in this component would be to have a way to track which tab is actively selected and update similar tabs to the same selected tab. Also store this selected tab in localStorage potentially so that the preferred tab for the user is always selected across the site.