Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: automate stable releases with release-plz #762

Merged
merged 5 commits into from
Dec 4, 2024
Merged

ci: automate stable releases with release-plz #762

merged 5 commits into from
Dec 4, 2024

Conversation

antonbaliasnikov
Copy link
Contributor

@antonbaliasnikov antonbaliasnikov commented Dec 3, 2024 •
edited
Loading

What 💻

  • Automate stable releases with release-plz

When a new commit is merged to main branch, a special release-plz workflow will be started that will do two things:

  1. If new change is merged - create or update a release PR for the next release with the new info from this commit identifying new semantic version, updating Cargo.toml.
  2. If this PR is merged, then new tag v*.*.* will be created that will initiate a new zksync-foundry release workflow that will create a new version release.

Changelog updates by release-plz as well as GitHub releases generated by this tool, and release of crates to crates.io are switched off for now (until requested) because ZKsync foundry is using its own changelog and release flow with binaries in release.yaml workflow.

Why ✋

Fixes #750

@antonbaliasnikov antonbaliasnikov requested a review from a team as a code owner December 3, 2024 15:05
@antonbaliasnikov antonbaliasnikov force-pushed the 750-automate-stable-releases-for-installation-method-use branch from d96da8d to 3dadcfa Compare December 3, 2024 15:08
nbaztec
nbaztec reviewed Dec 3, 2024
View reviewed changes
release-plz.toml Outdated Show resolved Hide resolved
release-plz.toml Outdated Show resolved Hide resolved
@antonbaliasnikov @nbaztec
Update release-plz.toml
50cec62 
Co-authored-by: Nisheeth Barthwal <[email protected]>
@dutterbutter dutterbutter requested a review from nbaztec December 4, 2024 13:55
nbaztec
nbaztec previously approved these changes Dec 4, 2024
View reviewed changes
@antonbaliasnikov antonbaliasnikov force-pushed the 750-automate-stable-releases-for-installation-method-use branch from 88a2891 to ec92248 Compare December 4, 2024 15:28
@antonbaliasnikov
Copy link
Contributor Author

@nbaztec , @dutterbutter I've just updated to the final version. Can you, please, approve once again?

@antonbaliasnikov antonbaliasnikov merged commit 2a54657 into main Dec 4, 2024
21 checks passed
@antonbaliasnikov antonbaliasnikov deleted the 750-automate-stable-releases-for-installation-method-use branch December 4, 2024 16:08
@antonbaliasnikov
Copy link
Contributor Author

antonbaliasnikov commented Dec 4, 2024 •
edited
Loading

@nbaztec , @dutterbutter
I merged PR and CI is now failing with the wrong permissions for zksync-era-bot user.
This is expected for now and we're working with security to fix it properly. I'll monitor the situation and fix it as soon as I can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nbaztec nbaztec nbaztec approved these changes

@dutterbutter dutterbutter Awaiting requested review from dutterbutter

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Automate stable releases for installation method use
3 participants
@antonbaliasnikov @nbaztec @dutterbutter