Skip to content

Commit

Permalink
fix: enable manual finalization by default
Browse files Browse the repository at this point in the history
  • Loading branch information
JackHamer09 committed Jun 5, 2024
1 parent 039bd1e commit 02a2804
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 17 deletions.
9 changes: 1 addition & 8 deletions views/transactions/Deposit.vue
Original file line number Diff line number Diff line change
Expand Up @@ -130,14 +130,7 @@
<CommonButton type="submit" variant="primary" class="mt-block-gap w-full gap-1" @click="buttonContinue()">
I understand, proceed to bridge
</CommonButton>
<CommonButton
as="a"
href="https://zksync.dappradar.com/ecosystem?category=defi_bridge"
target="_blank"
size="sm"
class="mx-auto mt-block-gap w-max"
@click="disableWalletWarning()"
>
<CommonButton size="sm" class="mx-auto mt-block-gap w-max" @click="disableWalletWarning()">
Don't show again
</CommonButton>
</template>
Expand Down
3 changes: 1 addition & 2 deletions views/transactions/Transfer.vue
Original file line number Diff line number Diff line change
Expand Up @@ -491,8 +491,7 @@ const withdrawalManualFinalizationRequired = computed(() => {
if (!transaction.value) return false;
return (
props.type === "withdrawal" &&
(isCustomNode ||
isWithdrawalManualFinalizationRequired(transaction.value.token, eraNetwork.value.l1Network?.id || -1))
isWithdrawalManualFinalizationRequired(transaction.value.token, eraNetwork.value.l1Network?.id || -1)
);
});
Expand Down
8 changes: 1 addition & 7 deletions views/transactions/WithdrawalSubmitted.vue
Original file line number Diff line number Diff line change
Expand Up @@ -149,9 +149,7 @@
<script lang="ts" setup>
import { ExclamationTriangleIcon } from "@heroicons/vue/24/outline";
import { isWithdrawalManualFinalizationRequired } from "@/composables/zksync/useTransaction";
import useWithdrawalFinalization from "@/composables/zksync/useWithdrawalFinalization";
import { isCustomNode } from "@/data/networks";
const props = defineProps({
transaction: {
Expand All @@ -172,11 +170,7 @@ const { connectorName, isCorrectNetworkSet } = storeToRefs(onboardStore);
const isCustomBridgeToken = computed(() => !props.transaction.token.l1Address);
const withdrawalManualFinalizationRequired = computed(() => {
return (
!props.transaction.info.completed &&
(isCustomNode ||
isWithdrawalManualFinalizationRequired(props.transaction.token, eraNetwork.value.l1Network?.id || -1))
);
return !props.transaction.info.completed;
});
const withdrawalFinalizationAvailable = computed(() => {
return (
Expand Down

0 comments on commit 02a2804

Please sign in to comment.