Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: move away from Ganache-style returns #415

Open
itegulov opened this issue Nov 24, 2024 · 0 comments
Open

fix: move away from Ganache-style returns #415

itegulov opened this issue Nov 24, 2024 · 0 comments

Comments

@itegulov
Copy link
Contributor

I believe historically our JSONRPC API has been following Ganache style for method results. For example, this is the declaration for Ganache's evm_setAccountNonce:

evm_setAccountNonce(address: string, nonce: string): Promise<boolean>

It returns boolean that regulates whether the requested work was applied or not. As opposed to anvil's anvil_setNonce that returns nothing:

fn anvil_set_nonce(&self, address: Address, nonce: U256) -> Result<()>

We should follow anvil's approach here although the impact of this difference is most likely negligible.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant