Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement matching of census-like persons to vista-like trips #4

Open
dhixsingh opened this issue Oct 2, 2020 · 3 comments
Open

Implement matching of census-like persons to vista-like trips #4

dhixsingh opened this issue Oct 2, 2020 · 3 comments
Assignees

Comments

@dhixsingh
Copy link
Member

We do not currently do any sensible matching of the sampled census-like persons to the generated vista-like trips. Any matching performed is arbitrary. For this reason, we do not write out the census attributes in the final MATSim XML output currently.

The code to be improved is here:

demand/R/match.R

Lines 16 to 17 in 266d481

# TODO: to be replaced with demographics based matching
echo(paste0('Matching census-like persons to VISTA-like plans\n'))

@dhixsingh dhixsingh self-assigned this Oct 2, 2020
dhixsingh added a commit that referenced this issue Mar 3, 2021
dhixsingh added a commit that referenced this issue Mar 10, 2021
dhixsingh added a commit that referenced this issue Mar 10, 2021
dhixsingh added a commit that referenced this issue Mar 11, 2021
dhixsingh added a commit that referenced this issue Mar 15, 2021
dhixsingh added a commit that referenced this issue Mar 16, 2021
dhixsingh added a commit that referenced this issue Mar 16, 2021
dhixsingh added a commit that referenced this issue Mar 16, 2021
@dhixsingh
Copy link
Member Author

The example population generation script now incorporates demographics-based trips generation. The sampled census person is matched to one of 5 VISTA demographic cohorts, and the activities/trips are generated based on the model for that cohort. Available since c45f9be.

@dhixsingh dhixsingh assigned jafshin and unassigned dhixsingh Apr 1, 2021
@jafshin
Copy link
Member

jafshin commented Apr 15, 2021

The cohort-based population generation is implemented and working since c45f9be.

However, the agent-id won't be kept at final XML which makes it complicated to joining demographics to plans. Also, there was a very low number of 65+ travellers in our cohort compared to VISTA "travellers" 65+.

Next steps:

  • @alanboth - to explore if skipping those not travelling instead of removing them will address the 65+ deviation
  • @dhixsingh - to add agent-id to the final XML writer

@jafshin jafshin assigned dhixsingh and alanboth and unassigned jafshin Apr 16, 2021
@dhixsingh dhixsingh changed the title Implement matching of census-link persons to vista-like trips Implement matching of census-like persons to vista-like trips Oct 3, 2023
@dhixsingh
Copy link
Member Author

@jafshin this can be closed now?

@dhixsingh dhixsingh assigned jafshin and unassigned dhixsingh Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants