This repository has been archived by the owner on Apr 26, 2024. It is now read-only.
-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
Add client_secret_path
as alternative for client_secret
for OIDC config
#16030
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ma27
force-pushed
the
oidc-client_secret_file
branch
from
July 30, 2023 20:23
fcdc6a6
to
989688c
Compare
Ma27
force-pushed
the
oidc-client_secret_file
branch
from
July 30, 2023 20:27
989688c
to
3cbce56
Compare
clokep
suggested changes
Aug 3, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks pretty reasonable; I wish we had a more abstract way of doing this instead of manually each time we want something to be a file.
That way you don't have to leak your bind password into your config. Useful for e.g. NixOS where config is stored in a world-readable location. Tested against a live synapse instance with authentik as OIDC provider. Signed-off-by: Maximilian Bosch <[email protected]>
Ma27
force-pushed
the
oidc-client_secret_file
branch
from
August 12, 2023 16:51
3cbce56
to
b1197c0
Compare
clokep
changed the title
oidc: add
Add Aug 15, 2023
client_secret_file
as alternative for client_secret
client_secret_path
as alternative for client_secret
for OIDC config
clokep
reviewed
Aug 15, 2023
clokep
reviewed
Aug 15, 2023
clokep
reviewed
Aug 15, 2023
clokep
reviewed
Aug 15, 2023
Co-authored-by: Patrick Cloke <[email protected]> Signed-off-by: Maximilian Bosch <[email protected]>
Ma27
force-pushed
the
oidc-client_secret_file
branch
from
August 21, 2023 13:31
343e5b2
to
8061107
Compare
Added relevant notes and squashed this and the previous commit together :) |
clokep
approved these changes
Aug 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Sorry for the back-and-forth here.
clokep
reviewed
Aug 21, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
That way you don't have to leak your bind password into your config. Useful for e.g. NixOS where config is stored in a world-readable location.
Tested against a live synapse instance with authentik as OIDC provider.
Pull Request Checklist
EventStore
toEventWorkerStore
.".code blocks
.(run the linters)