Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Warn that poetry will self-sabotage with zero-length setup.py files if interrupted. #14788

Open
ara4n opened this issue Jan 6, 2023 · 1 comment
Labels
A-Docs things relating to the documentation O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.

Comments

@ara4n
Copy link
Member

ara4n commented Jan 6, 2023

Repro steps:

  • Run poetry install --extras all -v on a git checkout
  • Interrupt it due to Speed up builds with large number of git ignored files python-poetry/poetry-core#499 not having been merged, and the fact that it gets stuck traversing a massive media store directory tree.
  • Don't notice that it's left a zero-length setup.py file in the root of the checkout
  • Run poetry install --extras all -v again
  • Discover it fails cryptically with:
  Obtaining file:///home/matrix/synapse
    Preparing metadata (setup.py): started
    Preparing metadata (setup.py): finished with status 'done'
  ERROR: No .egg-info directory found in /tmp/pip-pip-egg-info-81uum26d
  • Eventually figure out that you have to delete setup.py to make poetry stop mysteriously failing.

Filing this in case we want to update the Synapse guide to reflect this - or failing that, to leave a breadcrumb trail for others to find. Or i guess we could ask poetry to fix this horrific behaviour; i had to strace the wretched thing to figure out what the root cause was.

@DMRobertson DMRobertson added A-Docs things relating to the documentation S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks. O-Uncommon Most users are unlikely to come across this or unexpected workflow labels Jan 9, 2023
@DMRobertson
Copy link
Contributor

@reivilibre notes that -vv might give you extra debug information in this case.

We could add something to https://matrix-org.github.io/synapse/latest/development/dependencies.html#troubleshooting

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A-Docs things relating to the documentation O-Uncommon Most users are unlikely to come across this or unexpected workflow S-Tolerable Minor significance, cosmetic issues, low or no impact to users. T-Task Refactoring, removal, replacement, enabling or disabling functionality, other engineering tasks.
Projects
None yet
Development

No branches or pull requests

2 participants