Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix flakiness in "accepts own signatures" test #10

Open
AndrewFerr opened this issue Aug 1, 2023 · 2 comments
Open

Fix flakiness in "accepts own signatures" test #10

AndrewFerr opened this issue Aug 1, 2023 · 2 comments

Comments

@AndrewFerr
Copy link
Member

Every now and then, the test "OlmMachine › verifyBackup › accepts own signatures" in tests/machine.test.js fails in CI, but only for Node 20. Here's an example.

AFAICT the test awaits everything that it needs to, so something else must be going wrong here. This should be fixed not only to have reliable CI, but to see if this indicates is a real user-impacting issue.
@AndrewFerr
Copy link
Member Author

Looks like it happens in Node 19 too: https://github.com/matrix-org/matrix-rust-sdk-crypto-nodejs/actions/runs/5731568175/job/15532744078#step:8:49

@AndrewFerr
Copy link
Member Author

And in Node 18: https://github.com/matrix-org/matrix-rust-sdk-crypto-nodejs/actions/runs/5739890538/job/15556516262?pr=14#step:8:49

I'm beginning to suspect that this test's flakiness has nothing to do with the Node version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@AndrewFerr