Ensure "type" = "module" ES declaration in pre-release.sh #4350
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
BLCK-B
changed the title
robintown
approved these changes
Aug 15, 2024
Merged
via the queue into
matrix-org:develop
with commit Aug 15, 2024
d608039
33 of 36 checks passed
|
Sorry, this appears to be breaking our release process https://github.com/matrix-org/matrix-js-sdk/actions/runs/10469900988/job/28993898692 and is preventing me from doing a release. I'm going to have to revert this. |
richvdh
added a commit
that referenced
this pull request
Aug 20, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Aug 20, 2024
* Reapply "Add "type" = "module" to ensure it is present (#4350)" (#4352) This reverts commit 8214fd7. * Mark prettier config file as CommonJS I *think* this will fix a problem with the release process in which we saw an error: ``` Error: Invalid configuration for file "/home/runner/work/matrix-js-sdk/matrix-js-sdk/package.json": Error: module is not defined in ES module scope Error: This file is being treated as an ES module because it has a '.js' file extension and '/home/runner/work/matrix-js-sdk/matrix-js-sdk/package.json' contains "type": "module". To treat it as a CommonJS script, rename it to use the '.cjs' file extension. ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
public/exportedsymbols have accurate TSDoc documentation.Attempts to fix the issue #4347. Added a line in
scripts/pre-release.shthat should add"type" = "module"topackage.json. Analogous to 432aaa4.Reasoning:
CI order goes Release Process > Release Make >
pre-release.sh. It does not involve the other release script with the previous fix.Unfortunately, I can't test or verify. The CI workflows are too complex.
Signed-off-by: Jonas Black [email protected]