-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
V1 #53
Merged
Merged
V1 #53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
📢 Thoughts on this report? Let us know!. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains several internal and public API changes which include:
ISerializable
interface which makes theRead
andWrite
methods availableSBinaryWriter
instance is used and all subclasses write their data through it, this avoid all the memory allocations which were a consequence of the multipleGetBytes
method invocationsReader
class was renamed toParsecReader
, and its methods were renamed fromReadFromXXXX
toFromXXXX
, i.e.Parsec.ReadFromFile
->ParsecReader.FromFile
ItemDefinitionEp5
andItemDefinitionEp6
classes were merged into a singleItemDefinition
classFromXX
methodOverall, the public API hasn't changed much, but the internal changes resulted in reducing memory allocations and improved the performance considerably.