From 8fddaa3987a15c6a03b3e93de7a2551d9efc5bba Mon Sep 17 00:00:00 2001 From: VolodymyrBg Date: Mon, 16 Dec 2024 19:19:00 +0200 Subject: [PATCH 1/5] Update pull_request_template.md --- .github/pull_request_template.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 97aefde0..0008c75c 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -15,8 +15,8 @@ Please complete this section if any breaking changes have been made, otherwise d # Checklist -- [ ] I have added at least 2 reviewer or the whole pos-v1 team -- [ ] I have added sufficient documentation in code +- [ ] I have added at least 2 reviewers or the whole pos-v1 team +- [ ] I have added sufficient documentation in the code - [ ] I will be resolving comments - if any - by pushing each fix in a separate commit and linking the commit hash in the comment reply # Cross repository changes From 2758cdda7ee1cde75f1a30a93a0d19f2e3b5089d Mon Sep 17 00:00:00 2001 From: VolodymyrBg Date: Mon, 16 Dec 2024 19:25:30 +0200 Subject: [PATCH 2/5] Update milestones.md --- docs/milestones.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/milestones.md b/docs/milestones.md index 3c95e63d..93c1a524 100644 --- a/docs/milestones.md +++ b/docs/milestones.md @@ -1,6 +1,6 @@ ## Simulation tests for milestones -Milestone feature in the PoS V1 chain aims to make the finality of chain more deterministic rather than probabilistic. As it introduces explicit finality, it affects lot of people operating on the chain. The simulation based tests helps to generate different scenarios and test the feature effectively. +Milestone feature in the PoS V1 chain aims to make the finality of chain more deterministic rather than probabilistic. As it introduces explicit finality, it affects lot of people operating on the chain. The simulation based tests help to generate different scenarios and test the feature effectively. ### Branches to use and some exceptions From a0ae85ab7dcbfb64e11da923b5c6bb77ff34acac Mon Sep 17 00:00:00 2001 From: VolodymyrBg Date: Mon, 16 Dec 2024 19:41:52 +0200 Subject: [PATCH 3/5] Update index.js --- src/setup/devnet/index.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/setup/devnet/index.js b/src/setup/devnet/index.js index bea08528..321d0ef0 100644 --- a/src/setup/devnet/index.js +++ b/src/setup/devnet/index.js @@ -334,7 +334,7 @@ export class Devnet { this.config.targetDirectory ) - // TODO: Uncomment when finalised for docker setup + // TODO: Uncomment when finalized for docker setup // if (this.config.network) { // const chain = this.config.network // for (let i = 0; i < this.totalBorNodes; i++) { From c8d3fa9a424e0897db623b7b9541b3c218b983c8 Mon Sep 17 00:00:00 2001 From: VolodymyrBg Date: Mon, 16 Dec 2024 19:52:19 +0200 Subject: [PATCH 4/5] Update README.md --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index 94ffb8b7..e8980bba 100644 --- a/README.md +++ b/README.md @@ -165,7 +165,7 @@ The `express-cli` also comes with additional utility commands, listed below. Som - `../../bin/express-cli.js --update-erigon [index]` - Fetches `erigon` branch defined as `ERIGON_BRANCH` in `.env.devnet` file, pulls relative changes and restarts it on - the remote machines. If an integer `index` is used, the job will be performed only on the VM corresponding to that index. For example if the devnet consists of 2 bor and erigon nodes and you wanted to target the first erigon node, `index` will be 2. + the remote machines. If an integer `index` is used, the job will be performed only on the VM corresponding to that index. For example, if the devnet consists of 2 bor and erigon nodes and you want to target the first erigon node, `index` will be 2. - `../../bin/express-cli.js --update-heimdall [index]` From 6038c981fd003c1b4f30b9ff25fd24ff35c894a6 Mon Sep 17 00:00:00 2001 From: VolodymyrBg Date: Mon, 16 Dec 2024 19:53:00 +0200 Subject: [PATCH 5/5] Update secret.tfvars.example --- secret.tfvars.example | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/secret.tfvars.example b/secret.tfvars.example index 909d13b9..73316329 100644 --- a/secret.tfvars.example +++ b/secret.tfvars.example @@ -1,7 +1,7 @@ # 1. Copy this file to secret.tfvar (e.g. `cp secret.tfvars.example secret.tfvars`) # 2. Modify secret.tfvars by replacing the following with the list of IPs you want to allow # 3. For Polygon employees, these would be Bastillion and VPN IP addresses -# 4. If you don't know what are Bastillion and VPN IP addresses, please ask to the PoS team (ref. mardizzone@polygon.technology) +# 4. If you don't know what are Bastillion and VPN IP addresses, please ask the PoS team (ref. mardizzone@polygon.technology) # NOTE for Polygon employees: Do NOT use "0.0.0.0/0" for security reasons, otherwise the admin port will be open to the Internet! SG_CIDR_BLOCKS=["1.2.3.4/0", "5.6.7.8/0"]