-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support Dolt table diffs #94
Comments
@matiasb Curious if you have any update on this? |
hi! I think this exceeds the original goal of the project, so I'm not really sure how it would work as part of unidiff, although I can see it would be useful to have something like that for your use case. |
Is there a standard way you could see external project's writing a plugin to support their diff format? That seems like it could be a good solution. If so, I can take a look or raise the issue with the Dolt maintainers to get that written |
Right now there isn't an easy way (it wasn't previously considered either) to have a pluggable way to specify a custom diff format. That would require some work. I think the simpler path to get something working (given in this case it seems a specific scenario and scope) would be to fork and adapt the existing code, as a separate thing. I can try to help/answer questions as time permits. |
Dolt is a versionable MySQL database that can commit, branch, push, and pull just like a git repository. The diff output is similar enough to git's that
PatchSet
is able to parse it. However, the number of lines (or in Dolt's case the number of table rows) added/removed does not seem to get tracked correctly.For a basic Dolt setup, see this a minimal example I made. Taking the diff string of the
objects
table from my example, I tried unsuccessfully to parse the additions/deletions withunidiff
This outputs
Whereas it should've been 3 additions / 3 deletions from the
<>
syntax in the first ASCII column of the diff. Is there a way to support Dolt's table diffs?The text was updated successfully, but these errors were encountered: