-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disentangle collapse and explorer options #196
Comments
Yes. Check the |
Hmm. I tried all three options, and none seemed to change it from reading "collapsed equality" |
Thanks for checking. I can confirm Looks like a bug then. |
Perhaps not. From some discussion on #175, it seems like this is the expected and intended behavior. So this may be more of requesting an enhancement (adding an option to not collapse the speech output by default, or changing the algorithm that decides which equations to summarize) rather than reporting a bug. I personally like the idea of only summarizing display equations, but full acknowledge I don't have a solid understanding of what actually works best for screenreading users. |
#175 is about active exploration without the collapsing features; I'm referring to the top-level aria label which is generated for "read all" scenarios. |
#175 is still related, because switching on the explorer will automatically start the collapsible feature. One reason is that we wanted the most concise reading exposed in the aria-labels. Those rely on the maction elements being available to compute the summary. In general, we can now solve that problem as the new version of SRE can compute summaries without mactions. Obviously that does not change the problem of #175 that one does not always want summaries. |
Hm. I remember that that was always the case, but that the Now I'm not so sure anymore. Oh well.
This thread or #175? Feel free to rename. |
I ran into that problem the other day when I was putting together some test pages where I wanted explorer set by default but collapse always off, which could not be done, and I believe the aria-labels where the reason for that dependency. And we might as well then add an option on what type of labels should be generated. |
Sorry for the confusion, Peter. In referencing #175 I was trying to reference the discussion there, where Volker explained to me that the auto-collapsing of the speech aria-label was intentional, so not a bug. From a look at the code, it appears For my interests, I'm less concerned about being able to disable collapse (as in 175), and more interested in the possibility of adding a menu option to change whether the initially generated aria-labels are collapsed or not. From my very limited understanding of the code, it looks like that could be done relatively simply by adding a menu option that changes the Walker used in If this seems like a reasonable idea, I'm willing to take a stab at implementing it. |
I'm noticing that equations as simple as
f(x)=x
and2x=x+2
read as "collapsed equality". I'll fully admit I'm new to screenreading, but it seems like having to go into Explorer to read the equation for fairly short equalities like that would make screenreading the text much slower. Is there a way to prevent the collapsing? Am I missing something?The text was updated successfully, but these errors were encountered: