Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

My py3-ecrterm fork #10

Open
karolyi opened this issue Apr 24, 2018 · 8 comments
Open

My py3-ecrterm fork #10

karolyi opened this issue Apr 24, 2018 · 8 comments

Comments

@karolyi
Copy link

karolyi commented Apr 24, 2018

Hey guys,

just to inform you, I have implemented the TCP transport and upgraded the code here and there in my fork.

I have a python3.6+ only version, travis tests, enforced PEP8 checks, and the aforementioned TCP transport which 'works for me', but is still a work in progress. I had to fork it, but I do not plan to release it on pypi until I get the approval from here. Although I'm keeping that fork to have it working in my project.

Anyone is welcome to use it: https://github.com/karolyi/py3-ecrterm

@raphaelm
Copy link
Contributor

FYI, I also maintain a Python3.6 fork that fixed a number of things around passwords and configuration: https://github.com/raphaelm/ecrterm/tree/python3

@karolyi
Copy link
Author

karolyi commented Apr 24, 2018

@raphaelm, if you look at my fork, your changes are included. :)

@raphaelm
Copy link
Contributor

Great :)

@g4borg
Copy link
Collaborator

g4borg commented Feb 13, 2023

sorry guys, just stumbled on this topic here again by accident

if you are still maintaining it karolyi on your offsite branch, then I am fine with releasing it more broadly

If mathias does not object, which I doubt, and given I was the original author, I think I can decide this.

@karolyi
Copy link
Author

karolyi commented Feb 13, 2023

Hey @g4borg,

yes the project is maintained offsite. The offsite repo is still maintained at https://gitea.ksol.io/karolyi/py3-ecrterm, you can register there, I can give you commit access then. However I think you'll need a review before adding stuff since there were beginnings of TLV parsing as far as I can remember, which I merged as well. Those changes haven't been tested out. The py3 branch (should be set as default) contains them.

Let me know when you registered over there, so I can give you commit access.

@mborus
Copy link

mborus commented Mar 23, 2023

@karolyi - just looked at your gitea fork. Does it come with any documentation or a example, how to use the code?

@karolyi
Copy link
Author

karolyi commented Mar 23, 2023

@mborus I think https://gitea.ksol.io/karolyi/py3-ecrterm/src/branch/py3/test_pt.py should be it, but I haven't touched this codebase for a long time, since the project I built with it works ever since.

@mborus
Copy link

mborus commented Mar 23, 2023

@karolyi Thanks for the quick reply - that looks promising. I'll try it out next time I get my hands on ZVT terminal hardware. I wrote my own limited interface, but am not happy with it so I'm looking for alternatives.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants