You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
However, PyTask now fails to meet the criteria. A user can for example set auto_kwargs to True, which allows them to set whatever kwargs they feel like and this breaks the strict parameter checking.
We do need a fix for this soon. A few options:
Remove the list of optional_params from PyTask. This will also automatically skip parameter checking. The only downside here is that in order to see the list of optional parameters for PyTask, you need to read the docstring. Seems like the best solution to me.
Add an option to FireTaskBase to skip parameter checking. This seems clunky (yet another variable to know about!) and I'd discourage this
Remove the auto_kwargs option from PyTask. Downsides are that it breaks backward compatibility and also removes the ability to use that function for people that like it. Potential upside is that this parameter is probably confusing to most people anyway. I'd also discourage this solution, at the very least due to not wanting to break backward compatibility.
The text was updated successfully, but these errors were encountered:
We recently added strict parameter checking to FireTasks when a developer specified
optional_params
- see discussion here for context:hackingmaterials/atomate#295
However, PyTask now fails to meet the criteria. A user can for example set
auto_kwargs
to True, which allows them to set whatever kwargs they feel like and this breaks the strict parameter checking.We do need a fix for this soon. A few options:
The text was updated successfully, but these errors were encountered: