Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor search/periodic search #28

Open
conlain-k opened this issue Jun 25, 2021 · 1 comment
Open

Refactor search/periodic search #28

conlain-k opened this issue Jun 25, 2021 · 1 comment

Comments

@conlain-k
Copy link
Collaborator

Currently there is a lot of code duplication between the regular and "periodic table" search + pagination. I propose combining/refactoring them somehow as discussed (and partially implemented by @noahbsmith) in #25 and #26.
@noahbsmith
Copy link
Collaborator

If you merge my fork of this project, I have already done the refactoring on my branch feature/periodic_table_search

https://github.com/noahbsmith/materialhub-ui.git

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@conlain-k @noahbsmith