Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Theme: All Menu Items Not Showing on Desktop Tab Menu #84

Open
ravichdev opened this issue Apr 13, 2021 · 4 comments
Open

Theme: All Menu Items Not Showing on Desktop Tab Menu #84

ravichdev opened this issue Apr 13, 2021 · 4 comments
Assignees

Comments

@ravichdev
Copy link
Contributor

ravichdev commented Apr 13, 2021

Issue by ravichdev
Thursday Mar 25, 2021 at 18:42 GMT
Originally opened as xwp/material-design-wp-plugin#571


Feature description

The tab menu on desktop renders only limited menu items and the items exceeding the limit are always hidden and cannot be viewed or focused.

https://wordpress.org/support/topic/all-menu-items-not-showing-on-desktop-tabs/


Do not alter or remove anything below. The following sections will be managed by moderators only.

Acceptance criteria

  1. When a user adds more than 4 menu items present a warning message: "Too many menu items may require scrolling."
  2. Add to Appearance>Menu
  3. Add to customizer
  4. On the front end on desktop, provide a visual indicator that more tabs are available off screen.
  5. On the front end on mobile and desktop, offset the first tab on the left to signal that tabs are scrollable.

See https://material.io/components/tabs#scrollable-tabs

4

image

5

image

Implementation brief

QA testing instructions

Demo

Changelog entry

@jauyong jauyong added this to the 0.3.0 milestone Apr 21, 2021
@jauyong
Copy link
Collaborator

jauyong commented Apr 22, 2021

@rodydavis what are your thoughts on adding a visual indicator on the menu to let the user know they can scroll to see more?

@rodydavis
Copy link
Member

I think that we should stick to the material guidance here. What do other solutions do for long menus?

@PatelUtkarsh PatelUtkarsh removed this from the 0.3.0 milestone Jun 3, 2021
@jauyong
Copy link
Collaborator

jauyong commented Sep 21, 2021

@jauyong to verify if this bug is still outstanding (scrolling on desktop)

@jauyong
Copy link
Collaborator

jauyong commented Sep 21, 2021

I have verified that you are able to scroll on desktop so the bug is essentially closed. We can however still implement the AC to improve UX when there are too many tabs to display and scrolling is required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants