You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
As I'm getting deeper into the project, I had a few ideas for some mild refactors we could consider. Might make it easier for newcomers to jump in. Totally optional, of course, just wanted to bring it up as a topic of discussion. These aren't in order or anything:
move http helpers from besticon.go into fetch.go. move color helpers from lettericon.go into color.go. etc.
update iconserver HTML, for example removing old references to heroku app
add struct for lettericon path parsing
I see colorfinder has a main(). does that still work?
should we remove FindBestIcon? That confused me at first
add type Config & config.go to handle environment variables, command line flags and query arguments
fix linting errors (I think vscode is using golint)
would it be helpful to centralize utility functions and assertions? I am new to golang, so pardon my ignorance here.
reacted with thumbs up emoji reacted with thumbs down emoji reacted with laugh emoji reacted with hooray emoji reacted with confused emoji reacted with heart emoji reacted with rocket emoji reacted with eyes emoji
-
As I'm getting deeper into the project, I had a few ideas for some mild refactors we could consider. Might make it easier for newcomers to jump in. Totally optional, of course, just wanted to bring it up as a topic of discussion. These aren't in order or anything:
besticon.go
intofetch.go
. move color helpers fromlettericon.go
intocolor.go
. etc.main()
. does that still work?FindBestIcon
? That confused me at firsttype Config
&config.go
to handle environment variables, command line flags and query argumentsbesticon
,icoparser
)Just some random ideas. The project has a great test suite so this kind of work is pretty straightforward.
Beta Was this translation helpful? Give feedback.
All reactions