Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

QR code scanning does not work on MicroG / Degoogled devices #825

Open
LucasGGamerM opened this issue Apr 16, 2024 · 2 comments · May be fixed by #861
Open

QR code scanning does not work on MicroG / Degoogled devices #825

LucasGGamerM opened this issue Apr 16, 2024 · 2 comments · May be fixed by #861

Comments

@LucasGGamerM
Copy link
Contributor

I took a look the code responsible by doing this, and it seems like we are using google's mlkit to do the work for us. Could that be the reason as for why it doesn't work on a degoogled phone?

And does that mean that we also indirectly depend on google for the qr code scanning capabilities?
@grishka
Copy link
Member

grishka commented Apr 16, 2024

It is the reason it doesn't work with MicroG.

The reason I used Google's QR code scanner is that it doesn't require the camera permission. Otherwise, the ZXing library already included in app for generating QR codes can also scan them, but this is not implemented, at least for now.

@LucasGGamerM
Copy link
Contributor Author

LucasGGamerM commented Apr 17, 2024 •
edited
Loading

Moving to an in app solution would be nice, specially considering gms is a privacy nightmare. Not needing the camera permission is something we should at least consider giving up for the sake of better compatibility and more privacy.

Forgive the previous rant, as depending on GMS for anything other than push notifications is not a good idea (and not even that at times).

FineFindus added a commit to FineFindus/moshidon that referenced this issue Jul 8, 2024
@FineFindus
feat: fallback to zxing-based lib to scan QrCodes
4db8512 
Uses a zxing-based library as a fallback when scanning a Qr-Code and GMS
is not available.

Closes mastodon#825
@FineFindus FineFindus linked a pull request Jul 8, 2024 that will close this issue
Open
FineFindus added a commit to FineFindus/moshidon that referenced this issue Jul 8, 2024
@FineFindus
feat: fallback to zxing-based lib to scan QrCodes
f5517f3 
Uses a zxing-based library as a fallback when scanning a Qr-Code and GMS
is not available.

Closes mastodon#825
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: fallback to zxing-based lib to scan QrCodes FineFindus/moshidon
2 participants
@grishka @LucasGGamerM