Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactors form mapping into smaller functions for clarity #41

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
Open

Refactors form mapping into smaller functions for clarity #41

wants to merge 12 commits into from

Commits on Mar 4, 2015

  1. Removes unnecessary variable.

    @murrekatt
    murrekatt committed Mar 4, 2015
    Configuration menu
    Copy the full SHA
    5a32ee8 View commit details
    Browse the repository at this point in the history

  2. Proper variable usage.

    @murrekatt
    murrekatt committed Mar 4, 2015
    Configuration menu
    Copy the full SHA
    0ddf227 View commit details
    Browse the repository at this point in the history

  3. Refectors for clarity and to avoid variable shadowing.

    @murrekatt
    murrekatt committed Mar 4, 2015
    Configuration menu
    Copy the full SHA
    6550649 View commit details
    Browse the repository at this point in the history

  4. Changes naming for clarity.

    @murrekatt
    murrekatt committed Mar 4, 2015
    Configuration menu
    Copy the full SHA
    6c2e871 View commit details
    Browse the repository at this point in the history

  5. Moves out mapForm main for loop logic into own function.

    @murrekatt
    murrekatt committed Mar 4, 2015
    Configuration menu
    Copy the full SHA
    86b9c9e View commit details
    Browse the repository at this point in the history

  6. Moves out mapping field value into own function mapFormFieldValue.

    @murrekatt
    murrekatt committed Mar 4, 2015
    Configuration menu
    Copy the full SHA
    796cc88 View commit details
    Browse the repository at this point in the history

  7. Moves out mapping form multiparts into own function mapFormFieldMulti… 

    …part.
    @murrekatt
    murrekatt committed Mar 4, 2015
    Configuration menu
    Copy the full SHA
    7a5cd90 View commit details
    Browse the repository at this point in the history

  8. Refactors control flow for less nesting and clearer code.

    @murrekatt
    murrekatt committed Mar 4, 2015
    Configuration menu
    Copy the full SHA
    276d9ca View commit details
    Browse the repository at this point in the history

  9. Cleans up the last else statement for mapping the form.

    @murrekatt
    murrekatt committed Mar 4, 2015
    Configuration menu
    Copy the full SHA
    74192f8 View commit details
    Browse the repository at this point in the history

  10. Refactors and splits up form mapping logic into smaller functions and… 

    … separates out slice handling.
    @murrekatt
    murrekatt committed Mar 4, 2015
    Configuration menu
    Copy the full SHA
    0fd5bd5 View commit details
    Browse the repository at this point in the history

  11. Changes back to using i as index variable name.

    @murrekatt
    murrekatt committed Mar 4, 2015
    Configuration menu
    Copy the full SHA
    4727c48 View commit details
    Browse the repository at this point in the history

  12. Splits out form mapping into own file.

    @murrekatt
    murrekatt committed Mar 4, 2015
    Configuration menu
    Copy the full SHA
    5eb0973 View commit details
    Browse the repository at this point in the history