Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add individual overground lines #2932

Merged
merged 3 commits into from
Nov 28, 2024
Merged

Add individual overground lines #2932

merged 3 commits into from
Nov 28, 2024

Conversation

martincostello
Copy link
Owner

@martincostello martincostello commented Nov 28, 2024

  • Add colours for the new individual overground lines.
  • Use CSS variables for the line colours.
  • If someone still has london-overground as a preference, automatically return all the new individual lines instead.
  • Fix DLR appearing before District.

- Add colours for the new individual overground lines.
- Use CSS variables for the line colours.
@martincostello martincostello added bug enhancement .NET Pull requests that update .net code labels Nov 28, 2024
Copy link
Collaborator

@costellobot costellobot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop https://localhost:50001

Device URL
mobile https://localhost:50001

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Copy link

codecov bot commented Nov 28, 2024

Codecov Report

Attention: Patch coverage is 26.66667% with 11 lines in your changes missing coverage. Please review.

Project coverage is 77.46%. Comparing base (c8228ce) to head (95df183).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
src/LondonTravel.Site/ApiModule.cs 15.38% 10 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2932      +/-   ##
==========================================
- Coverage   77.86%   77.46%   -0.40%     
==========================================
  Files         123      123              
  Lines        2503     2512       +9     
  Branches      380      381       +1     
==========================================
- Hits         1949     1946       -3     
- Misses        371      381      +10     
- Partials      183      185       +2     
Flag Coverage Δ
linux 77.46% <26.66%> (-0.40%) ⬇️
macos 77.46% <26.66%> (-0.40%) ⬇️
windows 77.42% <26.66%> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

If someone still has `london-overground` as a preference, automatically return all the new individual lines instead.
Fix `DLR` appearing before `District`.
@martincostello martincostello marked this pull request as ready for review November 28, 2024 12:42
@martincostello martincostello merged commit e5e7009 into main Nov 28, 2024
13 of 15 checks passed
@martincostello martincostello deleted the overground-fixes branch November 28, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug enhancement .NET Pull requests that update .net code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants