Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clip too early #50

Open
innerlee opened this issue Sep 16, 2017 · 1 comment
Open

Clip too early #50

innerlee opened this issue Sep 16, 2017 · 1 comment

Comments

@innerlee
Copy link

The clip operation here is done before optimizerD.step(). So the discriminator used in updating G is the un-clampped version, which is not consistent with the paper.

@hanstissot
Copy link

Exactly! This seems to be an error in the code. I wonder if the difficulties that people have encountered in training WGANs is because of this error. Have you heard back from the authors?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants