Merge pull request #22 from garbast/improve_group_check

Add membership check
marketing-factory · Mar 19, 2020 · 8f19e6b · 8f19e6b
2 parents db13d41 + 899a13e
commit 8f19e6b
Showing 1 changed file with 11 additions and 1 deletion.
diff --git a/Classes/ResourceServer/GitLab.php b/Classes/ResourceServer/GitLab.php
@@ -157,7 +157,17 @@ public function loadUserDetails(ResourceOwnerInterface $user): void
             }
             if (isset($project['shared_with_groups']) && is_array($sharedGroups = $project['shared_with_groups'])) {
                 foreach ($sharedGroups as $sharedGroup) {
-                    $accessLevel = max($accessLevel, $sharedGroup['group_access_level']);
+                    try {
+                        $response = $gitlabClient
+                            ->getHttpClient()
+                            ->get('groups/' . $sharedGroup['group_id'] . '/members/' . $user->getId());
+                        // only assign access level is current user is member of group
+                        if ($response->getStatusCode() == 200) {
+                            $accessLevel = max($accessLevel, $sharedGroup['group_access_level']);
+                        }
+                    } catch (\Exception $ex) {
+                        // user has no access to see details
+                    }
                 }
             }
             if ($this->blockExternalUser && $user->isExternal()) {