Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remappings versioning refactor #123

Open
mario-eth opened this issue Aug 5, 2024 · 1 comment
Open

Remappings versioning refactor #123

mario-eth opened this issue Aug 5, 2024 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@mario-eth
Copy link
Owner

When a remapping is created, the name of the dependency should contain the version as well.
e.g.
@openzeppelin-4.9.0

This should be refactored to let the user choose what part of the versioning should be included:
major, major.minor, major.minor.patch, none

@mario-eth mario-eth added enhancement New feature or request good first issue Good for newcomers labels Aug 5, 2024
@beeb
Copy link
Collaborator

beeb commented Sep 29, 2024

I guess this is somewhat mitigated by the fact that version requirement strings can be used to specify how dependencies are allowed to update. Example: 5 would allow versions >=5.0.0,<6.0.0, and the remappings would contain library-name-5.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants